Encrypt/Decrypt/Sign/Verify using RSA in Transit backend #3489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalnayak
force-pushed
the
encrypt-rsa
branch
2 times, most recently
from
8c41bcb
to
da8df10
Compare
vishalnayak
force-pushed
the
encrypt-rsa
branch
from
da8df10
to
3ea2ec7
Compare
vishalnayak
changed the title
vishalnayak
force-pushed
the
encrypt-rsa
branch
from
5ab1fef
to
4acd786
Compare
chrishoffman
previously approved these changes
Nov 2, 2017
jefferai
reviewed
Nov 2, 2017
| } | ||
| } | ||
|
|
||
| return "", fmt.Errorf("unknown key type %v", policy.Type) | ||
| } | ||
|
|
||
| func encodeRSAPrivateKey(key *rsa.PrivateKey) string { |
There was a problem hiding this comment.
IIUC this actually depends on the format. For PKCS1 yes, but PKCS8 I believe should just be PRIVATE KEY because the type is encoded into the binary block. Might be worth mentioning that in the comment for the future as Go 1.10 will have PKCS8 encoding support and we will be adding it to PKI in this release.
jefferai
reviewed
Nov 2, 2017
builtin/logical/transit/path_keys.go
Outdated
| } | ||
| // Not making the header 'RSA PUBLIC KEY' since the format is | ||
| // of generic public key and not specifically of RSA. If its | ||
| // 'RSA PUBLIC KEY', 'openssl' complains. |
There was a problem hiding this comment.
Just PUBLIC KEY is correct since openssl (and x509) use PKIX and the type is encoded into the marshaled bytes. Can remove this comment!
jefferai
previously approved these changes
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reviewers, script used to test is here: https://gist.github.com/vishalnayak/4bd3b7d9eb28956d1517e8a49b1c47c4