Fixes for SSH command CA mode #3922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
approved these changes
Feb 12, 2018
vishalnayak
approved these changes
Feb 12, 2018
|
Thanks! |
Crazybus
added a commit
to Crazybus/vault
that referenced
this pull request
Jun 1, 2018
This is implementing the same fix that was added for the CA mode for vault ssh in hashicorp#3922 Using the IP address caused `Host` entries in the ssh_config to not match anymore meaning you would need to hardcode all of your IP addresses in your ssh config instead of using DNS to connect to hosts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issues #3920 by adding
valid-principalsflag for CA mode to allow it to differ from the SSH username. Also avoids converting SSH host to IP address so it can match hostname principal in host certificate.