Properly forward (or specifically don't) sys calls that result in read-only errors #4129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only errors. Prior to this policy writes against a performance secondary would not succeed because the read-only error was swallowed by handleError. In addition to fixing this, it adds a similar function that explicitly doesn't trigger forwarding. This is useful for things that are local to the secondary such as raw operations and lease management.
calvn
approved these changes
Mar 15, 2018
calvn
reviewed
Mar 15, 2018
|
|
||
| // Performs a similar function to handleError, but upon seeing a ReadOnlyError | ||
| // will actually strip it out to prevent forwarding | ||
| func handleErrorNoReadOnlyForward( |
There was a problem hiding this comment.
Maybe an opportunity to refactor and dedup this so that it's just a single method with an additional param, but this will do for now.
vishalnayak
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this policy writes against a performance secondary would not
succeed because the read-only error was swallowed by handleError. In
addition to fixing this, it adds a similar function that explicitly
doesn't trigger forwarding. This is useful for things that are local to
the secondary such as raw operations and lease management.