Using SSL to encrypt connections to MYSQL #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivienschilis
changed the title
|
I think the right label would be storage/mysql After looking at other hashicorp project I think the param should be called |
|
@vivienschilis Yes that would be a better name |
| ) | ||
|
|
||
| var ( | ||
| tlsKey = "custom" |
There was a problem hiding this comment.
Can you add a commend to what this is? Also it is better as a const with a prefix like mysqlTLSKey since otherwise it could collide in the physical package
vivienschilis
force-pushed
the
feature-tls-mysql
branch
3 times, most recently
from
9f086a6
to
35db9be
Compare
|
@armon Let me know if you wish more tweaks on that PR. |
|
@vivienschilis Can you add documentation for the |
vivienschilis
force-pushed
the
feature-tls-mysql
branch
2 times, most recently
from
df12140
to
de2218d
Compare
|
@armon 👍 |
armon
added a commit
that referenced
this pull request
Aug 5, 2015
Using SSL to encrypt connections to MYSQL
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to specify a certificate params "sslca" to encrypt the connections.
Taken from sql-driver documentation: https://github.com/go-sql-driver/mysql#tls
Don't hesitate to comment on the naming "sslca", I followed ActiveRecord's naming.
Cheers,
Vivien