Add plugin CLI for interacting with the plugin catalog #4911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briankassouf
previously approved these changes
Jul 13, 2018
command/plugin_deregister.go
Outdated
| helpText := ` | ||
| Usage: vault plugin deregister [options] NAME | ||
|
|
||
| Deregister an existing plugin in the catalog. This command requires sudo |
There was a problem hiding this comment.
I wonder if this will confuse people into thinking they need to do sudo vault plugin deregister ...? I don't have a great suggestion for alternative phrasing though, maybe ".. requires a privileged vault user?" but that's true of all vault commands 🤷
There was a problem hiding this comment.
Hmm yea - I agree with you. I'm going to remove it because I can see it causing problems.
briankassouf
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following commands, docs, and tests:
plugin listplugin registerplugin deregisterplugin infoIt also fixes a small bug I found in the API library.