Add support for "sovereign" Azure cloud environments #4997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
physical/azure/azure.go
Outdated
| client, err := storage.NewBasicClient(accountName, accountKey) | ||
| cloudEnvironmentName := os.Getenv("AZURE_ENVIRONMENT") | ||
| if cloudEnvironmentName == "" { | ||
| cloudEnvironmentName = conf["cloudEnvironment"] |
There was a problem hiding this comment.
I think environment should be suitable for the config element.
|
@chrishoffman I pushed an update that drops the "cloud" from the variable names and config parameter. |
chrishoffman
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of the Azure physical storage backend in vault 0.10.4 creates the storage client by means of the Azure storage SDK's function
NewBasicClient(accountName, accountKey). This function unconditionally assumes the storage account belongs to the Azure "public" cloud. It therefore is not possible to make vault 0.10.4 use a blob storage created in one of the "sovereign" Azure clouds (like Azure Germany) as its backend.This PR adds the parameter
cloudEnvironmentto the configuration of the Azure physical storage backend. It also obtains the Azure storage client by callingNewBasicClientOnSovereignCloud(accountName, accountKey, cloudEnvironment). Since the config parametercloudEnvironmentdefaults to"AzurePublicCloud", the change is backwards compatible. Users of one of the sovereign cloud environments have now the option to specify a storage account in their respective environment, though.