Fix group alias loading when identity memdb is initialized #5289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalnayak
reviewed
Sep 6, 2018
| @@ -1092,6 +1086,12 @@ func (i *IdentityStore) UpsertGroupInTxn(txn *memdb.Txn, group *identity.Group, | |||
| // Increment the modify index of the group | |||
| group.ModifyIndex++ | |||
|
|
|||
| if group.Alias != nil { | |||
There was a problem hiding this comment.
This block is also present in https://github.com/hashicorp/vault/blob/master/vault/identity_store.go#L222 which needs to be removed.
vishalnayak
approved these changes
Sep 6, 2018
|
We'd like this PR to be in sooner. So we'll be addressing the comment post-merge. Thanks for submitting this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5288
This move the MemDB Alias upsert deeper in UpsertGroupInTxn which get called in loadGroups at initialization.
This way aliases get initialized properly when loading groups from storagePacker