Allow @ to be part of key name in TOTP secret engine #5652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the pattern in |
kalafut
approved these changes
Oct 31, 2018
jefferai
reviewed
Oct 31, 2018
| @@ -14,7 +14,7 @@ import ( | |||
|
|
|||
| func pathCode(b *backend) *framework.Path { | |||
| return &framework.Path{ | |||
| Pattern: "code/" + framework.GenericNameRegex("name"), | |||
| Pattern: "code/" + framework.GenericNameWithAtRegex("name"), | |||
There was a problem hiding this comment.
Are we likely to see this used elsewhere? Should this really be in the framework package?
There was a problem hiding this comment.
It is unlikely that we see it elsewhere. I originally had it in the totp package itself, but then moved to framework to keep it close to GenericNameRegex to increases chances of changes to that reflected in this as well.
jefferai
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5645