Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: change backends template so that the icon shows in a namespace #5692

Merged
merged 2 commits into from
Nov 5, 2018
Merged

UI: change backends template so that the icon shows in a namespace #5692

merged 2 commits into from
Nov 5, 2018

Conversation

meirish
Copy link
Contributor

@meirish meirish commented Nov 5, 2018

Some of the templates needed engineType and methodType instead of type so that they weren't prefixed with ns_ when you're in namespace.

This also removes the plugin block from those templates as they will be unnecessary after #5536 lands.

screen shot 2018-11-05 at 4 31 47 pm
screen shot 2018-11-05 at 4 54 13 pm
screen shot 2018-11-05 at 4 54 21 pm

@meirish meirish added this to the 1.0 milestone Nov 5, 2018
@meirish meirish requested review from a team November 5, 2018 22:59
@meirish meirish merged commit 62c981c into master Nov 5, 2018
@meirish meirish deleted the ui-namespace-engine-icon branch November 5, 2018 23:12
@joshuaogle
Copy link
Contributor

Glad it was an easy fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@meirish @joshuaogle