Remove an empty line for /pki/ca_chain #5779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fix #5778. Easy test case to reproduce the problem: https://play.golang.org/p/CAMdrOHT7C1 Since `certStr` is empty string during first iteration `strings.Join()` will merge empty line with first CA cert. Extra `strings.TrimSpace` call will remove that empty line, before certificate will be return.
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #5778.
Easy test case to reproduce the problem:
https://play.golang.org/p/CAMdrOHT7C1
Since
certStris empty string during first iterationstrings.Join()will merge empty line with first CA cert.
Extra
strings.TrimSpacecall will remove that empty line, beforecertificate will be return.