UI - web cli layout #5909
Merged
UI - web cli layout #5909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
andaley
reviewed
Dec 7, 2018
| @@ -7,7 +7,7 @@ | |||
| <meta http-equiv="expires" content="0" /> | |||
| <meta http-equiv="pragma" content="no-cache" /> | |||
| <title>Vault</title> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1, viewport-fit=cover"> | |||
There was a problem hiding this comment.
ooh, iphone x stuff? fancy 💅
andaley
reviewed
Dec 7, 2018
| assert.equal(enginesPage.rows.length, numEngines + 3, 'new engines were added to the page'); | ||
| }); | ||
|
|
||
| test('fullscreen command expands the cli panel', async function(assert) { |
There was a problem hiding this comment.
I think these assertions are pretty solid. The only scenario which I can think of (although the assertions below may cover it) would be to test that the nav itself is still visible when the console is fullscreen.
There was a problem hiding this comment.
Yep, so in fullscreen, the nav isn't supposed to be on the page (we animate it up while we animate the console panel down).
andaley
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the nav re-styling I think we forgot to test
fullscreen- triggering that mode resulted in both the nav and the web-cli being placed above the viewport which isn't the most user-friendly place :).While trouble shooting this, I also noticed that the web cli didn't show up at all on iOS devices. Tracking that down was a bit more of an adventure because any attempt to inspect it with safari dev tools lead to the application crashing.
In the end, I moved the
console/ui-panelcomponent out of thenavin the nav-header component, instead opting to make it a sibling of thenavelement.I also made a couple of changes that makes the ui look nicer on iOS devices with notches.
Fixes #5901