Dynamic OpenAPI UI #6209
Dynamic OpenAPI UI #6209
Conversation
…nto openapi-models
| details.type = 'number'; | ||
| } | ||
| let editType = details.type; | ||
| if (details.format === 'seconds') { |
There was a problem hiding this comment.
will seconds always mean it's a ttl?
There was a problem hiding this comment.
that was my understanding. @kalafut is this the case?
There was a problem hiding this comment.
correction: seconds means it's a duration, meaning a ttl form field would make most sense
…eed to know anything about it
| //as determined by the expandOpenApiProps util | ||
| getProps(helpUrl, path, backend) { | ||
| return this.ajax(helpUrl, backend).then(help => { | ||
| let props = help.openapi.paths[path].post.requestBody.content['application/json'].schema.properties; |
There was a problem hiding this comment.
Do we know here that there will always be one path (at least until we get to more complex stuff with CRUD views, etc)? if so, what do you think about doing paths[0] instead of paths[path] ? When looking through the other code I wasn't sure what path was in those objects, but if this is all we're using it for, maybe we don't need it...
There was a problem hiding this comment.
paths is an object, so it's either this or doing something like
let path = Object.keys( help.openapi.paths)[0]
let props = paths[path].post.requestBody.content['application/json'].schema.properties;
There was a problem hiding this comment.
Ahh yeah I didn't realize that, but yeah what do you think about getting the keys if there's only going to be one?
| { default: ['organization'] }, | ||
| { | ||
| 'GitHub Options': ['baseUrl'], | ||
| }, | ||
| ]; | ||
| if (this.newFields) { | ||
| groups = combineFieldGroups(groups, this.newFields, []); |
There was a problem hiding this comment.
this combines the fields we have defined in the model with those returned from OpenAPI. new fields should not be added to the model -- ideally we should transition to only using fields from OpenAPI since it's meant to be the source of truth.
|
|
||
| const { attr } = DS; | ||
|
|
||
| export default AuthConfig.extend({ | ||
| useOpenAPI: true, |
There was a problem hiding this comment.
whether or not this model class should be re-opened and extended with additional fields from OpenAPI.
pull just frontend commits from #6129