Support reading Vault's address from Agent's config file #6306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, but i think we should also be adding the TLS config options here too. |
jefferai
reviewed
Feb 28, 2019
jefferai
reviewed
Feb 28, 2019
calvn
reviewed
Feb 28, 2019
Co-Authored-By: vishalnayak <vishalnayak@users.noreply.github.com>
|
@briankassouf @jefferai The TLS options are now added and they go through the logic of env and flag checking before the config takes effect. I have added |
calvn
approved these changes
Feb 28, 2019
|
@vishalnayak client cert and client key is an important one to get in. A lot of users use client authentication with TLS |
jefferai
added a commit
that referenced
this pull request
Jul 17, 2019
Several env vars got renamed in #6306. This re-adds support for those. Indirectly addresses hashicorp/consul-template#1233 although they should still update to the new values.
jefferai
added a commit
that referenced
this pull request
Jul 17, 2019
Several env vars got renamed in #6306. This re-adds support for those. Indirectly addresses hashicorp/consul-template#1233 although they should still update to the new values.
jefferai
added a commit
that referenced
this pull request
Jul 17, 2019
Several env vars got renamed in #6306. This re-adds support for those. Indirectly addresses hashicorp/consul-template#1233 although they should still update to the new values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.