Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix order of arguments for path-service #6540

Merged
merged 2 commits into from
Apr 5, 2019
Merged

fix order of arguments for path-service #6540

merged 2 commits into from
Apr 5, 2019

Conversation

meirish
Copy link
Contributor

@meirish meirish commented Apr 5, 2019 •
edited
Loading

The arguments in the getNewModel call were transposed so it was causing an error in SSH OTP credential generation. This wasn't caught because we didn't have any tests for this, so I added those as well 🎉.

Fixes #6539

@meirish meirish added this to the 1.1.1 milestone Apr 5, 2019
@meirish meirish requested review from a team April 5, 2019 20:05
madalynrose
madalynrose approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@madalynrose madalynrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find! also awesome tests

@meirish meirish merged commit 5da2f30 into master Apr 5, 2019
@meirish meirish deleted the ui-ssh-otp-gen branch April 5, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madalynrose madalynrose madalynrose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@meirish @madalynrose