Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http timeout values are configurable #6666

Merged
6 commits merged into from
May 10, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented May 1, 2019

No description provided.

@ghost ghost force-pushed the alex/configurable-http-server-timeouts branch 2 times, most recently from 62698c9 to f367e97 Compare May 3, 2019 01:09
@ghost ghost marked this pull request as ready for review May 3, 2019 01:13
@ghost ghost changed the title sharing work http timeout values are configurable May 3, 2019
@ghost ghost requested a review from briankassouf May 3, 2019 01:13
@ghost ghost force-pushed the alex/configurable-http-server-timeouts branch from f367e97 to a8c1459 Compare May 3, 2019 01:14
command/server.go Outdated Show resolved Hide resolved
Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the one comment.

@ghost ghost force-pushed the alex/configurable-http-server-timeouts branch from a8c1459 to 95ec131 Compare May 6, 2019 16:04
jefferai
jefferai previously approved these changes May 6, 2019
@jefferai jefferai added this to the 1.1.3 milestone May 6, 2019
@ghost
Copy link
Author

ghost commented May 6, 2019

fixes #6007

briankassouf
briankassouf previously approved these changes May 9, 2019
Copy link
Member

@briankassouf briankassouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Just needs docs, those can come in a follow on PR if you want

@ghost ghost dismissed stale reviews from briankassouf and jefferai via 3b0901f May 10, 2019 17:08
@ghost ghost merged commit 90ff541 into master May 10, 2019
@ghost ghost deleted the alex/configurable-http-server-timeouts branch May 10, 2019 17:41
briankassouf pushed a commit that referenced this pull request Jun 4, 2019
* http timeout fields are configurable

* move return statement for server config tests outside of range loop

* adds documentation for configurable listener http_* values

* fixed some formatting for the docs markdown
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants