Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update handleRollback to support both PeriodicFunc and handleWALRollback #6717

Merged
merged 1 commit into from
May 10, 2019

Conversation

catsby
Copy link
Contributor

@catsby catsby commented May 10, 2019

This PR changes the behavior of Backends that provide both PeriodicFunc and WALRollback. Currently if both are defined only the PeriodicFunc gets invoke and we return a nil response and the PeriodicFunc's error.

With this change, we invoke the PeriodicFunc if set and append its error response to a multierror error, if any. We then continue and call b.handleWALRollback, appending it's error if any, and return its response and the multierror.


@catsby catsby requested a review from jefferai May 10, 2019 15:40
@catsby catsby changed the title Update handleRollback to run both PeriodicFunc and handleWALRollback Update handleRollback to support both PeriodicFunc and handleWALRollback May 10, 2019
@catsby catsby merged commit 43ecb08 into master May 10, 2019
@catsby catsby deleted the periodic-and-wall-rollback branch May 10, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants