fix saving of TTL and string array fields generated by Open API #7094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madalynrose
approved these changes
Jul 15, 2019
| @@ -62,6 +62,7 @@ export default Component.extend({ | |||
| * | |||
| */ | |||
| inputList: computed(function() { | |||
| /* eslint-disable ember/no-side-effects */ | |||
There was a problem hiding this comment.
what side effect are we allowing here?
There was a problem hiding this comment.
Here's the rule: https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-side-effects.md And looking at this now, I think we should change this to happen on init, but since this is a backport I didn't want to do it here. I'll make a follow up PR!
There was a problem hiding this comment.
But why do we need it?
There was a problem hiding this comment.
Linting was failing on this - looks like the ignore was added at some point in master after 1.1.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already fixed in master and the 1.2 betas, so this back ports the fix for 1.1.4.
Fixes #6901