Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LDAP parameter to allow old-style group CN matching #7208

Merged
merged 3 commits into from
Jul 29, 2019

Conversation

jefferai
Copy link
Member

Tested manually; the online test server we use doesn't have suitable
groups for being able to exercise this.

Tested manually; the online test server we use doesn't have suitable
groups for being able to exercise this.
@jefferai jefferai added this to the 1.1.4 milestone Jul 29, 2019
Copy link
Collaborator

@ncabatoff ncabatoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine, I wonder if it'd be better to name the config option less generically? e.g. stick in an "uppercase" somewhere?

@jefferai jefferai merged commit ed3af7d into 1.1.5 Jul 29, 2019
@jefferai jefferai deleted the fix-ldap-group-cn-matching branch July 29, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants