Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PCF auth plugin to CF #7346

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Rename PCF auth plugin to CF #7346

merged 2 commits into from
Aug 26, 2019

Conversation

tyrannosaurus-becks
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks commented Aug 21, 2019

This PR renames the PCF auth plugin to CF, Cloud Foundry's current preference. The plugin repository on which it depends has already undergone renaming.

In keeping with the example set by the new TokenUtil fields, this PR is fully backwards-compatible. For now, it supports both "pcf" and "cf" as commands. However, all documents are updated to the new method, and all PCF fields are marked for future deprecation, which we can do at an appropriate time.

This PR has been tested in the following manner:

  • A full run of it from the CLI using the original manner of enabling it, configuring it, adding a role, and logging in.
  • A full run of it from the CLI using the new manner of the same.
  • A full run of it from the CLI using a hybrid manner where it was enabled in the past way but used in the modern way.

kalafut
kalafut previously approved these changes Aug 26, 2019
Copy link
Contributor

@kalafut kalafut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. A couple of other related items outside the scope of the PR would be:

  • update old changelog references
  • request to update the blog post (maybe?)

malnick
malnick previously approved these changes Aug 26, 2019
Copy link
Contributor

@malnick malnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants