Support batch tokens in renewer and caching proxy for transit auto-unseal #7441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalafut
reviewed
Sep 6, 2019
jefferai
force-pushed
the
batch-renewer
branch
from
fe5ca0a
to
0b698ff
Compare
jefferai
added a commit
that referenced
this pull request
Sep 9, 2019
…seal (#7441) Currently this uses a fork of the api.Renewer code, which we should consolidate in 1.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a series of small changes.
The first makes api.Renewer work properly with batch tokens. It will not attempt to renew them, and instead will simply exit when it is time to reauthenticate, using the same logic to calculate that time as service tokens.
The others make it possible to use agent's caching proxy with Transit auto unseal. This includes allowing token to be passed in, and not trying to start a renewer if no token is passed in.