Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not swallow ControlGroupErrors when viewing or editing kvv2 secrets #7504

Merged
merged 17 commits into from
Oct 4, 2019
Merged

do not swallow ControlGroupErrors when viewing or editing kvv2 secrets #7504

merged 17 commits into from
Oct 4, 2019

Commits on Oct 3, 2019

  1. do not swallow ControlGroupErrors when viewing or editing kvv2 secrets

    @andaley
    andaley committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    0540873 View commit details
    Browse the repository at this point in the history

  2. test kv v2 control group workflow

    @andaley
    andaley committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    5bd69a2 View commit details
    Browse the repository at this point in the history

  3. do not manually clearModelCache when logging out since this already h… 

    …appens when leaving the logout route
    @andaley
    andaley committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    21496d0 View commit details
    Browse the repository at this point in the history

  4. remove pauseTest

    @andaley
    andaley committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    7633272 View commit details
    Browse the repository at this point in the history

  5. update comments

    @andaley
    andaley committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    3a4a766 View commit details
    Browse the repository at this point in the history

  6. wip - looking into why restricted user can see the control group prot… 

    …ected secret after it has already been unwrapped once
    @andaley
    andaley committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    ab682e7 View commit details
    Browse the repository at this point in the history

  7. strip version from query params so we can unwrap a secret after it is… 

    … authorized
    @andaley
    andaley committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    76e4219 View commit details
    Browse the repository at this point in the history

  8. use attachCapabilities instead of lazyCapabilities to ensure models a… 

    …re cleaned up properly
    @andaley
    andaley committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    2b78015 View commit details
    Browse the repository at this point in the history

  9. remove comment

    @andaley
    andaley committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    d375c1b View commit details
    Browse the repository at this point in the history

  10. make ControlGroupError extend AdapterError

    @andaley
    andaley committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    a01afd3 View commit details
    Browse the repository at this point in the history

  11. fix broken redirect_to test

    @andaley
    andaley committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    b0c2c16 View commit details
    Browse the repository at this point in the history

  12. one day i will remember to remove my debugger statements; today is no… 

    …t that day
    @andaley
    andaley committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    36d3a6c View commit details
    Browse the repository at this point in the history

  13. no need to check for a ControlGroupError since it extends an AdapterE… 

    …rror
    @andaley
    andaley committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    3b25d0d View commit details
    Browse the repository at this point in the history

  14. see if using EmberError instead of AdapterError fixes the browserstac… 

    …k tests
    @andaley
    andaley committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    14ddd67 View commit details
    Browse the repository at this point in the history

  15. Revert "see if using EmberError instead of AdapterError fixes the bro… 

    …wserstack tests"

This reverts commit 14ddd67.
    @andaley
    andaley committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    58aab40 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2019

  1. Merge branch 'master' into ui/check-for-controlgrouperror

    Noelle Daley committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    4549c24 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ui/check-for-controlgrouperror

    Noelle Daley committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    afd1989 View commit details
    Browse the repository at this point in the history