Backport 1.2.4: allow viewing kv-v2 secrets gated by control groups #7573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 4, 2019 14:05
#7504) * do not swallow ControlGroupErrors when viewing or editing kvv2 secrets * test kv v2 control group workflow * do not manually clearModelCache when logging out since this already happens when leaving the logout route * remove pauseTest * update comments * wip - looking into why restricted user can see the control group protected secret after it has already been unwrapped once * strip version from query params so we can unwrap a secret after it is authorized * use attachCapabilities instead of lazyCapabilities to ensure models are cleaned up properly * remove comment * make ControlGroupError extend AdapterError * fix broken redirect_to test * one day i will remember to remove my debugger statements; today is not that day * no need to check for a ControlGroupError since it extends an AdapterError * see if using EmberError instead of AdapterError fixes the browserstack tests * Revert "see if using EmberError instead of AdapterError fixes the browserstack tests" This reverts commit 14ddd67.
chrishoffman
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7504