Guard against using Raft as a seperate HA Storage #8239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalnayak
previously approved these changes
Feb 10, 2020
briankassouf
previously approved these changes
Feb 14, 2020
catsby
dismissed stale reviews from briankassouf and vishalnayak
via
ad0fd15
catsby
added a commit
that referenced
this pull request
Feb 14, 2020
* Guard against using Raft as a seperate HA Storage * Document that Raft cannot be used as a seperate ha_storage backend at this time * remove duplicate imports from updating with master
catsby
added a commit
that referenced
this pull request
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard against configuration that would use Raft solely for HA (e.g.
ha_storage "raft"with non-raftstorage) This "fixes" #8206 by preventing it from happening when parsing the config, but also guarding against calling any methods if the internalraftbackend is nil.It seems raft isn't initialized or started unless it's the primary physical storage used. Internally in the unseal process,
startRaftStoragegets called which setups the the raft cluster for storage, but it is not called for the configured HA backend. That may be an easy addition later, but for now we document the limitation and block it from happening to prevent further panics as shown in #8206