Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON encoding adding newlines. #8928

Merged
merged 7 commits into from
May 19, 2020
Merged

Fix JSON encoding adding newlines. #8928

merged 7 commits into from
May 19, 2020

Commits on May 18, 2020

  1. Fix JSON encoding adding newlines. 

    This manifested itself when encoding config values, which all map to
strings. An extra new line would get added by json.Encode, which caused
other things to break with confusing error messagges. Switching to
json.Marshal seems to solve the problem.
    @raskchanky
    raskchanky committed May 18, 2020
    Configuration menu
    Copy the full SHA
    b278938 View commit details
    Browse the repository at this point in the history

  2. go mod vendor

    @raskchanky
    raskchanky committed May 18, 2020
    Configuration menu
    Copy the full SHA
    701b0fc View commit details
    Browse the repository at this point in the history

  3. revert change to sdk

    @raskchanky
    raskchanky committed May 18, 2020
    Configuration menu
    Copy the full SHA
    277a280 View commit details
    Browse the repository at this point in the history

  4. use json.Marshal in config parsing

    @raskchanky
    raskchanky committed May 18, 2020
    Configuration menu
    Copy the full SHA
    ba7fc5c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into fix-json-parsing

    @raskchanky
    raskchanky committed May 18, 2020
    Configuration menu
    Copy the full SHA
    ff0061b View commit details
    Browse the repository at this point in the history

  6. remove the extra new line from the test

    @raskchanky
    raskchanky committed May 18, 2020
    Configuration menu
    Copy the full SHA
    d6ad3e9 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/fix-json-parsing' into fix-json-… 

    …parsing
    @raskchanky
    raskchanky committed May 18, 2020
    Configuration menu
    Copy the full SHA
    d10b4b4 View commit details
    Browse the repository at this point in the history