Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require AWS_ROLE_SESSION_NAME to sts:AssumeRoleWithWebIdentity #9416

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Don't require AWS_ROLE_SESSION_NAME to sts:AssumeRoleWithWebIdentity #9416

merged 2 commits into from
Jul 14, 2020

Conversation

orirawlings
Copy link
Contributor

Fixes #9415

@hashicorp-cla
Copy link

hashicorp-cla commented Jul 7, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kalafut kalafut added this to the 1.5 milestone Jul 14, 2020
tvoran
tvoran approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work for me when I tested on EKS. Thanks for the patch!

@kalafut kalafut modified the milestones: 1.5, 1.4.4 Jul 14, 2020
@tvoran
Copy link
Member

tvoran commented Jul 14, 2020

The test failures seem to be pre-existing on master, and pass locally.

TestSealMigration_TransitToShamir_Post14 - sealmigration
TestSealMigration_TransitToShamir_Post14/raft

@tvoran tvoran merged commit 95e05e5 into hashicorp:master Jul 14, 2020
tvoran added a commit that referenced this pull request Jul 14, 2020
@orirawlings @tvoran
Don't require AWS_ROLE_SESSION_NAME to sts:AssumeRoleWithWebIdentity (#…
52fa14b 
…9416)

Fixes #9415

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
@tvoran tvoran mentioned this pull request Jul 14, 2020
Merged
tvoran added a commit that referenced this pull request Jul 14, 2020
@orirawlings @tvoran
Don't require AWS_ROLE_SESSION_NAME to sts:AssumeRoleWithWebIdentity (#…
1d56fe3 
…9416)

Fixes #9415

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
@tvoran tvoran mentioned this pull request Jul 14, 2020
Merged
tvoran added a commit that referenced this pull request Jul 14, 2020
@tvoran @orirawlings
Don't require AWS_ROLE_SESSION_NAME to sts:AssumeRoleWithWebIdentity (#…
352d9fb 
…9416) (#9475)

Fixes #9415

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

Co-authored-by: Ori Rawlings <orirawlings@gmail.com>
tvoran added a commit that referenced this pull request Jul 14, 2020
@tvoran @orirawlings
Don't require AWS_ROLE_SESSION_NAME to sts:AssumeRoleWithWebIdentity (#…
39f1a3e 
…9416) (#9476)

Fixes #9415

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

Co-authored-by: Ori Rawlings <orirawlings@gmail.com>
This was referenced Jul 16, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvoran tvoran tvoran approved these changes

Assignees

@tvoran tvoran

Labels
backport
Projects
None yet
Milestone
1.5
4 participants
@orirawlings @hashicorp-cla @tvoran @kalafut