Update gocql version for cassandra physical backend #9602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncabatoff
approved these changes
Jul 27, 2020
|
Thanks @byumov ! |
|
@mladlow @ncabatoff We are on a patched version of Vault since v1.4.2 since July. Looks like the milestone is pushed down the road! Can this really be added in 1.6, please? :-) |
|
@andrejvanderzee - yes, this update will be included in 1.6 now that the PR has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of gocql library(using for Cassandra physical backend) more, than one year old now.
gocql is in active developing now and a lot of bugs were fixed.
For example, now we can't use Cassandra backend for Vault with old Cassandra version(2.0). It was fixed here: apache/cassandra-gocql-driver#1292
This PR just bump gocql version.