Ui/transform enable #9647
Merged
Ui/transform enable #9647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelshaw
commented
Jul 31, 2020
| } | ||
| if (this.get('version.isEnterprise')) { | ||
| mountEngines.push(TRANSFORM); |
There was a problem hiding this comment.
As I understand it, KMIP and Transform are enabled under the same module. So, we could treat KMIP the same way (shown for enterprise, but disabled unless the feature exists). However, that wasn't outlined in the designs to I kept it this way for now.
Monkeychip
reviewed
Jul 31, 2020
| @@ -0,0 +1,33 @@ | |||
| /** | |||
There was a problem hiding this comment.
nice! Thanks for creating this.
Monkeychip
reviewed
Jul 31, 2020
| @@ -12,10 +12,12 @@ const FEATURES = [ | |||
| 'Seal Wrapping', | |||
| 'Control Groups', | |||
| 'Namespaces', | |||
| 'KMIP', | |||
There was a problem hiding this comment.
Curious, why wasn't KMIP added in this previously?
There was a problem hiding this comment.
It looks like it was an oversight, because the places where we check for KMIP prior to this were in the component files, not on the template. But that's a great reminder to double-check that this doesn't have unintended side-effects
Monkeychip
approved these changes
Jul 31, 2020
Sure, I'll make one since Storybook-Docs isn't up and running yet |
chelshaw
added a commit
that referenced
this pull request
Aug 26, 2020
* Ui/transform enable (#9647) * Show Transform on engines list if enterprise * Add box-radio component * Add is-disabled styling for box-radio and fix tooltip styling when position: above * Add KMIP and Transform to possible features on has feature helper * Sidebranch: Transform Secret Engine Initial setup (#9625) * WIP // list transforms, console.logs and all * setup LIST transformations ajax request and draft out options-for-backend options * change from plural to singluar and add transform to secret-edit * create two transform edit components * modify transform model with new attrs * add adapterFor to connect transform adapter to transform-edit-form component * setup Allowed roles searchSelect component to search over new transform/role adapter and model. * clean up for PR * clean up linting errors * restructure adapter call, now it works. * remove console * setup template model for SearchSelect component * add props to form field and search select for styling Co-authored-by: Chelsea Shaw <chelshaw.dev@gmail.com> * Ui/transform language fixes (#9666) * Update casing and wording on Transform list route. Use generic list item for transformations * Add back js file for transformation-edit * Set up transform for tabs * Ui/create edit transformation fixes (#9668) * add conditional for masking vs tweak source based on type, and update text for create transformation * change order * fix error with stringArray * setup the edit/delete transformation view * clean up toolbar links * setup serializer to change response of mask character from keycode to character * change styling of label and sub-text size, confirmed with design * temp fix on templates vs template * add clickable list item * add space between template list * setup styling and structure for the rest of the show transformation. TODO: turn into components. * create transform-show-transformation component * add attachCapabilities to transform model and update transform-transformation-itme list accordingly * clean up liniting errors * address pr comments * remove leftover * clean up * Sidebranch: UI transform create and edit clean up (#9778) * clean up some of the TODOs * setup edit view with read only attributes for name and template * setup initial selected for search select component * fixes * hide templates form field for now * set selectLimit for search select component * hide power select if the select limit is greater than or equal to the selectedOptions length * clean up failing linting * address pr comments * Ui/fix list roles transformation (#9788) * Update search-select to pass backend to query if exists * Update role and template adapters * cleanup * Fix replace with static string * Ui/transform cleanup 2 (#9789) * amend encode/decode commands for now until design gets back with more details * restrict character count on masking input field * clean up selectLimit * show backend instead of transform in cli copy command * Show KMIP un-selectable if enterprise but no ADP module (#9780) * New component transform-edit-base * Duplicate RoleEdit as TransformEditBase and swap in all transform components * Roll back role-edit changes * Update to transform edit base * Remove extraeneous set backend type on transform components * formatting * Revert search-select changes * Update template/templates data on transformation (#9838) Co-authored-by: Angel Garbarino <Monkeychip@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, enterprise versions of Vault will show the transform secret engine option when adding a new secret engine. However, it will be disabled unless the appropriate module is licensed:
If the correct license exists, transform is selectable and is can be enabled in the same way any other engine is enabled:
