Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenLDAP secrets plugin 0.1.4 -> 0.1.5 #9673

Merged
merged 3 commits into from
Aug 10, 2020
Merged

Conversation

tomhjp
Copy link
Contributor

@tomhjp tomhjp commented Aug 6, 2020

This PR upgrades the OpenLDAP secrets plugin to v0.1.5, which includes a new ad schema for managing AD instances. See hashicorp/vault-plugin-secrets-openldap#16 for the feature PR, and #9619 for the docs PR.

Upgrade was performed via:

go get github.com/hashicorp/vault-plugin-secrets-openldap
go mod vendor
go mod tidy

go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The race condition failure seems suspicious, wondering if this is already known?

Copy link
Member

@calvn calvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to do go get github.com/hashicorp/vault-plugin-secrets-openldap (without the -u) to avoid updating all downstream dependencies.

I think bumping the version in go.mod followed by go mod vendor & go mod tidy should work fine.

@tomhjp
Copy link
Contributor Author

tomhjp commented Aug 7, 2020

Thanks @calvn - I've dropped the previous commit, rebased and done as suggested (without the -u). The diff is much smaller now and looks correct to me.

@tomhjp tomhjp merged commit 4fd17c2 into master Aug 10, 2020
@tomhjp tomhjp deleted the openldap-plugin-ad-schema branch August 10, 2020 09:23
tomhjp added a commit that referenced this pull request Aug 17, 2020
* Backport #9673: Update OpenLDAP secrets plugin 0.1.4 -> 0.1.5

* Add docs for OpenLDAP plugin's new AD schema (#9619)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants