-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OpenLDAP secrets plugin 0.1.4 -> 0.1.5 #9673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The race condition failure seems suspicious, wondering if this is already known?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to do go get github.com/hashicorp/vault-plugin-secrets-openldap
(without the -u) to avoid updating all downstream dependencies.
I think bumping the version in go.mod
followed by go mod vendor
& go mod tidy
should work fine.
d573dff
to
7a6bac9
Compare
Thanks @calvn - I've dropped the previous commit, rebased and done as suggested (without the |
This PR upgrades the OpenLDAP secrets plugin to v0.1.5, which includes a new
ad
schema for managing AD instances. See hashicorp/vault-plugin-secrets-openldap#16 for the feature PR, and #9619 for the docs PR.Upgrade was performed via: