Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh backend: Change the default signature algorithm to rsa-sha2-256 #9726

Closed
wants to merge 1 commit into from

Conversation

thomas-maurice
Copy link

The current default rsa-sha1 signature algorithm for SSH certificates is now no longer accepted by modern versions of SSH (> 8.2).

It would make sense to update it to another algorithm that works out of the box and provides an increased level of security.

@hashicorp-cla
Copy link

hashicorp-cla commented Aug 12, 2020

CLA assistant check
All committers have signed the CLA.

@ncabatoff
Copy link
Collaborator

Hi @thomas-maurice ,

Thanks for the PR. My concern with this change is that it may break existing deployments. I agree it's unfortunate that the default is no longer supported by newer OSes, but I'm not sure that's yet reason enough for this change.

@thomas-maurice
Copy link
Author

@ncabatoff this change only affects the setups that have not forced the algorithm to be rsa-sha1. Also I am not sure how it would break existing deployments as the rsa-sha1 signature algorithm is now deprecated anyways and the issued certs just won't work

@Blackclaws
Copy link

Blackclaws commented Nov 26, 2020

@ncabatoff I just ran into this exact same issue. Having the default be something that is still accepted in modern openssh versions would really help a lot. Or at least put a disclaimer onto the documentation page and an example of how to manually change this

@calvn
Copy link
Member

calvn commented Nov 30, 2020

I believe that this is (at least partially) addressed by #9824. The backend will use the key's signing algorithm if none is provided so if a cert has been signed with rsa-sha2-256, it will use that as the algorithm_signer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants