Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Update vault1.4.x to vault-plugin-secrets-azure 40b6e36f1c7 #9773

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Aug 18, 2020

Backport hashicorp/vault-plugin-secrets-azure#43 & hashicorp/vault-plugin-secrets-azure#45 to Vault 1.4.x. Specifically, this backports the release/vault-1.4.x branch of vault-plugin-secrets-azure to the release/1.4.x branch of Vault, and ran go mod vendor:

@catsby catsby changed the title Backport: Update to github.com/hashicorp/vault-plugin-secrets-azure 40b6e36f1c7 Backport: Update vault1.4.x to vault-plugin-secrets-azure 40b6e36f1c7 Aug 18, 2020
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kalafut kalafut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on merging this PR.

@catsby catsby marked this pull request as draft August 18, 2020 20:07
@catsby catsby force-pushed the backport-azure-42-vault-1.4.x branch from 54bacc9 to f3d8ad7 Compare August 21, 2020 10:49
@catsby catsby marked this pull request as ready for review August 21, 2020 10:50
@catsby catsby requested a review from kalafut August 21, 2020 10:52
@catsby
Copy link
Contributor Author

catsby commented Aug 24, 2020

Merging this in; @kalafut gave their 👍 internally

@catsby catsby merged this pull request into release/1.4.x Aug 24, 2020
@catsby catsby deleted the backport-azure-42-vault-1.4.x branch August 24, 2020 17:22
@mladlow mladlow added this to the 1.4.7 milestone Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants