Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 1.5: secrets/ssh: allow algorithm_signer to use the key's default algo (#9824) #9841

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Backport 1.5: secrets/ssh: allow algorithm_signer to use the key's default algo (#9824) #9841

merged 1 commit into from
Aug 26, 2020

Conversation

ncabatoff
Copy link
Collaborator

No description provided.

@calvn @ncabatoff
secrets/ssh: allow algorithm_signer to use the key's default algo (#9824
bd8e393 
)

* secrets/ssh: allow algorithm_signer to use the key's default algo

* add test for ed25519 key signing

* test: add role upgrade test case

* test: rename and add more test cases

* test: clean up tests cases, fix broken test case on expected error

* test: fix broken test case on expected error
@ncabatoff ncabatoff merged commit c2ac761 into release/1.5.x Aug 26, 2020
@ncabatoff ncabatoff deleted the backport-pr-9824-1.5.x branch August 26, 2020 20:06
@ncabatoff ncabatoff added this to the 1.5.3 milestone Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briankassouf briankassouf briankassouf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ncabatoff @briankassouf @calvn