Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

Update proto generation #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update proto generation #12

wants to merge 1 commit into from

Conversation

vmanilo
Copy link

@vmanilo vmanilo commented Aug 30, 2021

When using latest proto plugins:
google.golang.org/protobuf/cmd/protoc-gen-go@v1.26
google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1.1

protoc --version
libprotoc 3.17.0

getting error:
--go_out: protoc-gen-go: plugins are not supported; use 'protoc --go-grpc_out=...' to generate gRPC

This changes fix proto generation issue.

When using latest proto plugins:
google.golang.org/protobuf/cmd/protoc-gen-go@v1.26 
google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1.1

protoc --version
libprotoc 3.17.0

getting error:
--go_out: protoc-gen-go: plugins are not supported; use 'protoc --go-grpc_out=...' to generate gRPC


This changes fix proto generation issue.
@hashicorp-cla
Copy link

hashicorp-cla commented Aug 30, 2021

CLA assistant check
All committers have signed the CLA.

@briancain
Copy link
Member

Hey there @vmanilo - Currently, main Waypoint isn't on the latest versions of the proto plugins so for those pinned to older versions, this would break. I'm going to keep this open for now for reference if people wish to use the latest versions. We have some plans on how to make this proto gen better which should hopefully solve this version difference issue 😅

@christophermancini
Copy link

christophermancini commented Jan 26, 2022

I was able to generate the protos with even simpler commands:

	protoc -I . --go-grpc_out=. --go-grpc_opt=paths=source_relative ./builder/output.proto
	protoc -I . --go-grpc_out=. --go-grpc_opt=paths=source_relative ./registry/output.proto
	protoc -I . --go-grpc_out=. --go-grpc_opt=paths=source_relative ./platform/output.proto
	protoc -I . --go-grpc_out=. --go-grpc_opt=paths=source_relative ./release/output.proto

version of the plugin protoc-gen-go-grpc 1.2.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants