Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Commit

Permalink
Merge pull request #4833 from hashicorp/backport/missing-efs-panic/su…
Browse files Browse the repository at this point in the history
…btly-true-chipmunk

This pull request was automerged via backport-assistant
  • Loading branch information
hc-github-team-waypoint committed Jul 6, 2023
2 parents b00ef1c + d770db6 commit 51fbee1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .changelog/4829.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
runneruninstall/aws-ecs: Fix panic when uninstalling ECS runner after failing to find EFS
```
2 changes: 1 addition & 1 deletion internal/runnerinstall/ecs.go
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ func (i *ECSRunnerInstaller) Uninstall(ctx context.Context, opts *InstallOpts) e
}
}

if *fileSystemId == "" {
if fileSystemId == nil || *fileSystemId == "" {
s.Update("File system with tag key `runner-id` and value " + opts.Id + " not detected, skipping deletion")
s.Done()
return nil
Expand Down

0 comments on commit 51fbee1

Please sign in to comment.