Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog and since pragmas #422

Merged
merged 4 commits into from
Sep 15, 2021
Merged

Conversation

Bodigrim
Copy link
Contributor

We might wish to make a release before GHC 9.4 feature freeze, so bringing changelog into order.

Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

I think the following changes should be included too:

This looks like a well-sized changeset already. Is there a reason why we should hold off on cutting the 0.11.2.0 release?

In particular, I think that #401 looks like an important perf fix that should be included in the upcoming GHC 9.0 and 9.2 releases. (CC @bgamari)

Changelog.md Outdated Show resolved Hide resolved
@Bodigrim
Copy link
Contributor Author

@sjakobi thanks for suggestions, updated.

Is there a reason why we should hold off on cutting the 0.11.2.0 release?

Ideally I'd like to get #417 done in 0.11.2.0, time permitting. This would simplify things for utf8-backed text.

#365 is also a very desirable improvement and lingers in our pipeline for half a year, but I do not have bandwidth to review it properly. @sjakobi if you or anyone else have time to take a look, it would be much appreciated.

It's a difficult situation: on one side I do not like to tie ourselves to GHC release cycles, on the other hand if a breaking change lands into GHC before 9.4 feature freeze, we'll have to make another release of bytestring.

@sjakobi
Copy link
Member

sjakobi commented Sep 13, 2021

In general, I'm not a fan of tying (minor) releases to the completion of certain features. AFAIK (minor) releases are a fairly cheap process, so I wouldn't mind simply cutting another release once #365 or #417 are done.

#365 is also a very desirable improvement and lingers in our pipeline for half a year, but I do not have bandwidth to review it properly. @sjakobi if you or anyone else have time to take a look, it would be much appreciated.

I hadn't realized that this PR was waiting for a review! :/ I'll try to review it soon!

@Bodigrim Bodigrim merged commit 688f3c0 into haskell:master Sep 15, 2021
@Bodigrim Bodigrim deleted the changelog branch September 15, 2021 18:31
Bodigrim added a commit to Bodigrim/bytestring that referenced this pull request Oct 12, 2021
* Update changelog

* Add since pragmas for future 0.11.2.0

* Fix dangling links in haddocks

* Update changelog again
@Bodigrim Bodigrim added this to the 0.11.2.0 milestone Nov 3, 2021
@Bodigrim Bodigrim mentioned this pull request Dec 4, 2021
noughtmare pushed a commit to noughtmare/bytestring that referenced this pull request Dec 12, 2021
* Update changelog

* Add since pragmas for future 0.11.2.0

* Fix dangling links in haddocks

* Update changelog again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants