Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Home Assistant's HTTP reverse proxy configuration on add-on startup #254

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

lmagyar
Copy link
Contributor

@lmagyar lmagyar commented Sep 8, 2023

Proposed Changes

This will prevent "400: Bad Request" errors and redirects users to the Documentation.

Related Issues

@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Oct 9, 2023
@lmagyar
Copy link
Contributor Author

lmagyar commented Oct 10, 2023

not stale

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Oct 11, 2023
@frenck frenck added the enhancement Enhancement of the code, not introducing new features. label Oct 15, 2023
@frenck frenck marked this pull request as draft October 15, 2023 17:06
@lmagyar
Copy link
Contributor Author

lmagyar commented Oct 20, 2023

Rebased, to prevent merge conflicts (proxy service code will change a lot).

@frenck
Copy link
Member

frenck commented Oct 22, 2023

Note: the unrelated changes are already in PR #277, this PR needs to be rebased after that is merged.

Please don't stack your PRs on top of each other. Make them clean and standalone. Can you rebase this one and pick only the related commits? Thanks 👍

../Frenck

@lmagyar
Copy link
Contributor Author

lmagyar commented Oct 22, 2023

And rebased also.

@lmagyar lmagyar marked this pull request as ready for review October 23, 2023 09:16
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like reasonable way to handle this 👍

Thanks, @lmagyar 👍

../Frenck

@frenck frenck merged commit 7382fe4 into hassio-addons:main Oct 23, 2023
13 checks passed
@lmagyar lmagyar deleted the pr-test-proxy-connection branch October 23, 2023 15:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants