Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple lines in var.json #104

Merged
merged 1 commit into from
May 12, 2023
Merged

Allow multiple lines in var.json #104

merged 1 commit into from
May 12, 2023

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Mar 7, 2022 •
edited
Loading

Proposed Changes

  • Allow new lines to be used in values for the var.json
  • Properly escape all characters for a proper JSON string, not only line breaks
  • Fix issue when ^ character would be used in a key and the key would evaluated as key rather than "^key" leading to a non-valid JSON
  • Introduces a function var.json_string which escapes a Bash string for use in a JSON object

Related Issues

Fixes #94

@felipecrs felipecrs mentioned this pull request Mar 7, 2022
Closed
@github-actions

This comment was marked as duplicate.

Sign in to view
@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Apr 7, 2022
@felipecrs
Copy link
Contributor Author

I think this still deserves some attention. :)

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Apr 8, 2022
pvizeli
pvizeli reviewed Apr 11, 2022
View reviewed changes
Copy link
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have to test it

@github-actions

This comment was marked as duplicate.

Sign in to view
@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label May 12, 2022
@felipecrs
Copy link
Contributor Author

This is not stale

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label May 13, 2022
@github-actions

This comment was marked as duplicate.

Sign in to view
@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Jun 13, 2022
@felipecrs
Copy link
Contributor Author

Not stale, ready for review.

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Jun 14, 2022
@github-actions

This comment was marked as duplicate.

Sign in to view
@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Jul 15, 2022
@felipecrs
Copy link
Contributor Author

(I tested it, if that counts)

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Jul 16, 2022
@github-actions

This comment was marked as duplicate.

Sign in to view
@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Aug 15, 2022
@felipecrs
Copy link
Contributor Author

Not stale...

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Aug 16, 2022
@brenner-tobias

This comment was marked as off-topic.

Sign in to view
@github-actions

This comment was marked as duplicate.

Sign in to view
@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Oct 15, 2022
@felipecrs
Copy link
Contributor Author

Not stale

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Oct 16, 2022
@github-actions

This comment was marked as duplicate.

Sign in to view
@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Nov 16, 2022
@felipecrs
Copy link
Contributor Author

This is not stale, only pending review and merge?

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Nov 17, 2022
@github-actions

This comment was marked as duplicate.

Sign in to view
@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Dec 18, 2022
@felipecrs
Copy link
Contributor Author

Is there a way to tell the stale-bot to ignore this PR?

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Dec 19, 2022
@brenner-tobias

This comment was marked as off-topic.

Sign in to view
@github-actions

This comment was marked as off-topic.

Sign in to view
@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Feb 13, 2023
@felipecrs
Copy link
Contributor Author

Not stale.

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Feb 14, 2023
@github-actions

This comment was marked as duplicate.

Sign in to view
@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Mar 17, 2023
@felipecrs
Copy link
Contributor Author

:(

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Mar 18, 2023
@brenner-tobias

This comment was marked as off-topic.

Sign in to view
@falzm

This comment was marked as off-topic.

Sign in to view
@github-actions

This comment was marked as duplicate.

Sign in to view
@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label May 11, 2023
pvizeli
pvizeli approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's still fine. But it is not my project. @frenck ?

@frenck
Copy link
Member

frenck commented May 11, 2023 •
edited
Loading

You have access right @pvizeli :)

Feel free to merge and handle as such if you are ok with it 👍

@felipecrs
Copy link
Contributor Author

felipecrs commented May 11, 2023 •
edited
Loading

@frenck your feedback would also be appreciated nevertheless :)

frenck
frenck approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. Thanks, @felipecrs 👍

../Frenck

@frenck frenck merged commit d3e2077 into hassio-addons:main May 12, 2023
@frenck frenck added the new-feature New features or options. label May 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@pvizeli pvizeli pvizeli approved these changes

Assignees
No one assigned
Labels
new-feature New features or options. stale There has not been activity on this issue or PR for quite some time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow multi-line string in var.json
5 participants
@felipecrs @brenner-tobias @falzm @frenck @pvizeli