Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch config from API #82

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Fetch config from API #82

merged 2 commits into from
Nov 1, 2021

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Sep 26, 2021

Proposed Changes

As we start with that endpoints, the end of this way was to use the API data and not copy a file with secrets into each container and having that data persistent. It's not more persistent as to using the API for it.

Related Issues

(Github link to related issues or pull requests)

@pvizeli pvizeli requested a review from frenck September 26, 2021 16:32
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Oct 27, 2021
@frenck
Copy link
Member

frenck commented Oct 27, 2021

not stale bot... handled after the HA beta is done.

@frenck frenck added no-stale This issue or PR is exempted from the stable bot. and removed stale There has not been activity on this issue or PR for quite some time. labels Oct 27, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @pvizeli 👍

@frenck frenck merged commit 555dce6 into hassio-addons:main Nov 1, 2021
@frenck frenck added the enhancement Enhancement of the code, not introducing new features. label Nov 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features. no-stale This issue or PR is exempted from the stable bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants