refactor(cli): remove try-catch on comareCommits

hasundue · Aug 2, 2024 · 94b3ec0 · 94b3ec0
1 parent 4f4ced4
commit 94b3ec0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/cli/main_test.ts b/cli/main_test.ts
@@ -49,6 +49,10 @@ describe("CLI", () => {
     );
   });
 
+  it("should not throw with `--changelog`", async () => {
+    await molt("--changelog");
+  });
+
   it("should update `deno.json` with `--write`", async () => {
     const { stderr, stdout } = await molt("--write");
     assertEquals(

diff --git a/cli/src/changelog.ts b/cli/src/changelog.ts
@@ -48,13 +48,7 @@ export async function printChangelog(
     // The dependency was newly added in this update
     return;
   }
-  const messages: string[] = [];
-  try {
-    // The refs might not exist
-    messages.push(...await compareCommits(repo, oldest, to));
-  } catch {
-    return;
-  }
+  const messages = await compareCommits(repo, oldest, to);
   const root = await resolvePackageRoot(repo, pkg, to);
   if (!root) {
     // The package seems to be generated dynamically on publish