Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json formatter #3526

Closed
wants to merge 17 commits into from
Closed

Conversation

ashishra0
Copy link
Contributor

Description

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code
    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields
    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

Steps to test and verify

Limitations, known bugs & workarounds

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @ashishra0, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@ashishra0 ashishra0 closed this Dec 13, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-3526.herokuapp.com is deleted

@ashishra0 ashishra0 deleted the add-json-formatter branch December 13, 2019 04:30
@netlify
Copy link

netlify bot commented Dec 13, 2019

Deploy preview for hasura-docs ready!

Built with commit 6dbfaef

https://deploy-preview-3526--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit 6dbfaef deployed to Heroku: https://hge-ci-pull-3526.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3526-6dbfaefe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants