Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed doc links in index.rst #811

Closed
wants to merge 6 commits into from
Closed

Conversation

vinayak42
Copy link
Contributor

Description

Corrected the links to references in one getting-started doc. However, more need to be corrected. Please communicate whether I need to raise an issue and assign it to myself, to correct the links in rest of the docs.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

I'll raise an issue and self-assign it once you make sure this is correct.

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @vinayak42, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-811.herokuapp.com

@rikinsk-zz rikinsk-zz self-requested a review October 19, 2018 10:59
@rikinsk-zz
Copy link

rikinsk-zz commented Oct 19, 2018

@vinayak42 What exactly were you fixing here? The current differences seem unnecessary

@vinayak42
Copy link
Contributor Author

@rikinsk When I click on them, the current links redirect to the same page, and do not look properly formatted. Similar stuff happens to other doc links. Is it a problem on my end only?

@shahidhk
Copy link
Member

@vinayak42 Thanks for the contribution. But as @rikinsk mentioned, this change looks like it's not required. Feel free to work on another issue labelled hacktoberfest.

@shahidhk shahidhk closed this Oct 20, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-811.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants