Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http-log now correctly logs user information, closes #849 #850

Merged
merged 4 commits into from
Oct 25, 2018
Merged

http-log now correctly logs user information, closes #849 #850

merged 4 commits into from
Oct 25, 2018

Conversation

0x777
Copy link
Member

@0x777 0x777 commented Oct 24, 2018

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#849

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-850.herokuapp.com

@0x777 0x777 requested a review from rakeshkky October 25, 2018 07:19
rakeshkky
rakeshkky previously approved these changes Oct 25, 2018
View reviewed changes
@0x777 0x777 added the s/do-not-merge Do not merge this pull request to master label Oct 25, 2018
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-850.herokuapp.com

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-850.herokuapp.com

@0x777 0x777 added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels Oct 25, 2018
@0x777 0x777 merged commit 199531c into hasura:master Oct 25, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-850.herokuapp.com is deleted

rikinsk-zz pushed a commit to rikinsk-zz/graphql-engine that referenced this pull request Oct 25, 2018
@0x777 @rikinsk
http and websocket logs now correctly have user information, closes h…
0caccda 
…asura#849 (hasura#850)
hasura-bot pushed a commit that referenced this pull request Mar 22, 2021
@rakeshkky @hasura-bot
server: fix action output type generation (#850)
97549cc 
* fix action output type generation

* update CHANGELOG.md

GitOrigin-RevId: 558ff64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakeshkky rakeshkky rakeshkky left review comments

Assignees
No one assigned
Labels
s/ok-to-merge Status: This pull request can be merged to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x777 @hasura-bot @rakeshkky