Add translation manager interface (#128)

* [console] Add TranslatorManagerInterface class. * [console] Apply PSR-2 code style. * [console] Update docblocks.
hechoendrupal · Jan 2, 2017 · 21fa567 · 21fa567
1 parent fb116ed
commit 21fa567
Show file tree

Hide file tree

Showing 14 changed files with 127 additions and 59 deletions.
diff --git a/.php_cs b/.php_cs
@@ -0,0 +1,10 @@
+<?php
+
+return PhpCsFixer\Config::create()
+        ->setRules(
+            [
+                '@PSR2' => true,
+                'array_syntax' => ['syntax' => 'short'],
+            ]
+        )
+        ->setUsingCache(false);
diff --git a/phpqa.yml b/phpqa.yml
@@ -17,9 +17,6 @@ application:
     php-cs-fixer:
       enabled: true
       exception: false
-      file:
-        config-file: .php_cs
-        single-execution: false
       options:
         level: psr2
       arguments:
@@ -63,7 +60,7 @@ application:
       enabled: false
       exception: false
     phpunit:
-      enabled: true
+      enabled: false
       exception: true
       file:
         configuration: phpunit.xml.dist

diff --git a/src/Application.php b/src/Application.php
@@ -2,7 +2,7 @@
 
 namespace Drupal\Console\Core;
 
-use Drupal\Console\Core\Utils\TranslatorManager;
+use Drupal\Console\Core\Utils\TranslatorManagerInterface;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\EventDispatcher\EventDispatcher;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -24,6 +24,7 @@
 
 /**
  * Class Application
+ *
  * @package Drupal\Console
  */
 class Application extends BaseApplication
@@ -40,6 +41,7 @@ class Application extends BaseApplication
 
     /**
      * ConsoleApplication constructor.
+     *
      * @param ContainerInterface $container
      * @param string             $name
      * @param string             $version
@@ -55,7 +57,7 @@ public function __construct(
     }
 
     /**
-     * @return TranslatorManager
+     * @return TranslatorManagerInterface
      */
     public function getTranslator()
     {

diff --git a/src/Command/Shared/CommandTrait.php b/src/Command/Shared/CommandTrait.php
@@ -7,16 +7,17 @@
 
 namespace Drupal\Console\Core\Command\Shared;
 
-use Drupal\Console\Core\Utils\TranslatorManager;
+use Drupal\Console\Core\Utils\TranslatorManagerInterface;
 
 /**
  * Class CommandTrait
+ *
  * @package Drupal\Console\Core\Command
  */
 trait CommandTrait
 {
     /**
-     * @var  TranslatorManager
+     * @var TranslatorManagerInterface
      */
     protected $translator;
 

diff --git a/src/EventSubscriber/ShowGenerateChainListener.php b/src/EventSubscriber/ShowGenerateChainListener.php
@@ -12,17 +12,18 @@
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\Yaml\Dumper;
 use Symfony\Component\Console\Command\Command;
-use Drupal\Console\Core\Utils\TranslatorManager;
+use Drupal\Console\Core\Utils\TranslatorManagerInterface;
 use Drupal\Console\Core\Style\DrupalStyle;
 
 /**
  * Class ShowGenerateChainListener
+ *
  * @package Drupal\Console\Core\EventSubscriber
  */
 class ShowGenerateChainListener implements EventSubscriberInterface
 {
     /**
-     * @var TranslatorManager
+     * @var TranslatorManagerInterface
      */
     protected $translator;
 
@@ -55,10 +56,11 @@ class ShowGenerateChainListener implements EventSubscriberInterface
 
     /**
      * ShowGenerateChainListener constructor.
-     * @param TranslatorManager $translator
+     *
+     * @param TranslatorManagerInterface $translator
      */
     public function __construct(
-        TranslatorManager $translator
+        TranslatorManagerInterface $translator
     ) {
         $this->translator = $translator;
     }

diff --git a/src/EventSubscriber/ShowGenerateInlineListener.php b/src/EventSubscriber/ShowGenerateInlineListener.php
@@ -11,17 +11,18 @@
 use Symfony\Component\Console\Event\ConsoleTerminateEvent;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\Console\Command\Command;
-use Drupal\Console\Core\Utils\TranslatorManager;
+use Drupal\Console\Core\Utils\TranslatorManagerInterface;
 use Drupal\Console\Core\Style\DrupalStyle;
 
 /**
  * Class ShowGenerateInlineListener
+ *
  * @package Drupal\Console\Core\EventSubscriber
  */
 class ShowGenerateInlineListener implements EventSubscriberInterface
 {
     /**
-     * @var TranslatorManager
+     * @var TranslatorManagerInterface
      */
     protected $translator;
 
@@ -54,10 +55,11 @@ class ShowGenerateInlineListener implements EventSubscriberInterface
 
     /**
      * ShowGenerateInlineListener constructor.
-     * @param TranslatorManager $translator
+     *
+     * @param TranslatorManagerInterface $translator
      */
     public function __construct(
-        TranslatorManager $translator
+        TranslatorManagerInterface $translator
     ) {
         $this->translator = $translator;
     }

diff --git a/src/EventSubscriber/ShowTipsListener.php b/src/EventSubscriber/ShowTipsListener.php
@@ -11,26 +11,28 @@
 use Symfony\Component\Console\Event\ConsoleCommandEvent;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\Console\Command\Command;
-use Drupal\Console\Core\Utils\TranslatorManager;
+use Drupal\Console\Core\Utils\TranslatorManagerInterface;
 use Drupal\Console\Core\Style\DrupalStyle;
 
 /**
  * Class ShowTipsListener
+ *
  * @package Drupal\Console\Core\EventSubscriber
  */
 class ShowTipsListener implements EventSubscriberInterface
 {
     /**
-     * @var TranslatorManager
+     * @var TranslatorManagerInterface
      */
     protected $translator;
 
     /**
      * ShowGenerateChainListener constructor.
-     * @param TranslatorManager $translator
+     *
+     * @param TranslatorManagerInterface $translator
      */
     public function __construct(
-        TranslatorManager $translator
+        TranslatorManagerInterface $translator
     ) {
         $this->translator = $translator;
     }

diff --git a/src/EventSubscriber/ShowWelcomeMessageListener.php b/src/EventSubscriber/ShowWelcomeMessageListener.php
@@ -11,26 +11,28 @@
 use Symfony\Component\Console\Event\ConsoleCommandEvent;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\Console\Command\Command;
-use Drupal\Console\Core\Utils\TranslatorManager;
+use Drupal\Console\Core\Utils\TranslatorManagerInterface;
 use Drupal\Console\Core\Style\DrupalStyle;
 
 /**
  * Class ShowWelcomeMessageListener
+ *
  * @package Drupal\Console\Core\EventSubscriber
  */
 class ShowWelcomeMessageListener implements EventSubscriberInterface
 {
     /**
-     * @var TranslatorManager
+     * @var TranslatorManagerInterface
      */
     protected $translator;
 
     /**
      * ShowWelcomeMessageListener constructor.
-     * @param TranslatorManager $translator
+     *
+     * @param TranslatorManagerInterface $translator
      */
     public function __construct(
-        TranslatorManager $translator
+        TranslatorManagerInterface $translator
     ) {
         $this->translator = $translator;
     }

diff --git a/src/EventSubscriber/ValidateExecutionListener.php b/src/EventSubscriber/ValidateExecutionListener.php
@@ -12,17 +12,18 @@
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\Console\Command\Command;
 use Drupal\Console\Core\Utils\ConfigurationManager;
-use Drupal\Console\Core\Utils\TranslatorManager;
+use Drupal\Console\Core\Utils\TranslatorManagerInterface;
 use Drupal\Console\Core\Style\DrupalStyle;
 
 /**
  * Class ValidateExecutionListener
+ *
  * @package Drupal\Console\Core\EventSubscriber
  */
 class ValidateExecutionListener implements EventSubscriberInterface
 {
     /**
-     * @var TranslatorManager
+     * @var TranslatorManagerInterface
      */
     protected $translator;
 
@@ -33,11 +34,12 @@ class ValidateExecutionListener implements EventSubscriberInterface
 
     /**
      * ValidateExecutionListener constructor.
-     * @param TranslatorManager    $translator
-     * @param ConfigurationManager $configurationManager
+     *
+     * @param TranslatorManagerInterface $translator
+     * @param ConfigurationManager       $configurationManager
      */
     public function __construct(
-        TranslatorManager $translator,
+        TranslatorManagerInterface $translator,
         ConfigurationManager $configurationManager
     ) {
         $this->translator = $translator;

diff --git a/src/Utils/ShellProcess.php b/src/Utils/ShellProcess.php
@@ -9,6 +9,7 @@
 
 /**
  * Class ShellProcess
+ *
  * @package Drupal\Console\Core\Utils
  */
 class ShellProcess
@@ -19,7 +20,7 @@ class ShellProcess
     protected $appRoot;
 
     /**
-     * @var TranslatorManager
+     * @var TranslatorManagerInterface
      */
     protected $translator;
 
@@ -35,8 +36,9 @@ class ShellProcess
 
     /**
      * Process constructor.
-     * @param string            $appRoot
-     * @param TranslatorManager $translator
+     *
+     * @param string                     $appRoot
+     * @param TranslatorManagerInterface $translator
      */
     public function __construct($appRoot, $translator)
     {

diff --git a/src/Utils/ShowFile.php b/src/Utils/ShowFile.php
@@ -8,10 +8,10 @@
 namespace Drupal\Console\Core\Utils;
 
 use Drupal\Console\Core\Style\DrupalStyle;
-use Drupal\Console\Core\Utils\TranslatorManager;
 
 /**
  * Class ShowFileHelper
+ *
  * @package Drupal\Console\Core\Utils
  */
 class ShowFile
@@ -22,18 +22,19 @@ class ShowFile
     protected $root;
 
     /**
-     * @var TranslatorManager
+     * @var TranslatorManagerInterface
      */
     protected $translator;
 
     /**
      * ShowFile constructor.
-     * @param string            $root
-     * @param TranslatorManager $translator
+     *
+     * @param string                     $root
+     * @param TranslatorManagerInterface $translator
      */
     public function __construct(
         $root,
-        TranslatorManager $translator
+        TranslatorManagerInterface $translator
     ) {
         $this->root = $root;
         $this->translator = $translator;