Removed some warnings. (#317)

* Removed some warnings in drupal launcher and in-project. * Skip early instead.
hechoendrupal · Feb 17, 2018 · f9dbf4b · f9dbf4b
1 parent f998ed7
commit f9dbf4b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/Utils/ChainDiscovery.php b/src/Utils/ChainDiscovery.php
@@ -188,15 +188,15 @@ public function getChainCommands()
             $chainMetadata = $this->getFileMetadata($file);
 
             $chain = Yaml::parse($chainMetadata);
-            if (!array_key_exists('command', $chain)) {
+            if (!$chain || !array_key_exists('command', $chain)) {
                 continue;
             }
-            if (!array_key_exists('name', $chain['command'])) {
+            if (!is_array($chain['command']) || !array_key_exists('name', $chain['command'])) {
                 continue;
             }
             $name = $chain['command']['name'];
             $description = '';
-            if (array_key_exists('description', $chain['command'])) {
+            if (is_array($chain['command']) && array_key_exists('description', $chain['command'])) {
                 $description = $chain['command']['description'];
             }
             $chainCommands[$name] = [

diff --git a/src/Utils/ConfigurationManager.php b/src/Utils/ConfigurationManager.php
@@ -419,6 +419,9 @@ public function getSites()
             ];
 
             foreach ($environments as $environment => $config) {
+                if (!array_key_exists('type', $config)) {
+                    throw new \UnexpectedValueException("The 'type' parameter is required in sites configuration.");
+                }
                 if ($config['type'] !== 'local') {
                     if (array_key_exists('host', $config)) {
                         $targetInformation['remote'] = true;