Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require minimum stable version of dot-access-configuration #123

Closed
grasmash opened this issue Dec 29, 2016 · 15 comments
Closed

Require minimum stable version of dot-access-configuration #123

grasmash opened this issue Dec 29, 2016 · 15 comments

Comments

@grasmash
Copy link

grasmash commented Dec 29, 2016

The composer.json file for drupal-console-core currently requires "dev-master" for dflydev/dot-access-configuration. This does not follow best practices for a composer package, which dictate that a minimum stable version should be defined.

Would it be possible to change this constraint?

@jmolivas
Copy link
Member

@grasmash I will ping the maintainer and ask to tag a release since latest stable is broken when using symfony 3.x components.

@jmolivas
Copy link
Member

This is my PR dflydev/dflydev-dot-access-configuration#8 fixing the issue at the dflydev/dot-access-configuration project.

Releases page: https://github.com/dflydev/dflydev-dot-access-configuration/releases

@greg-1-anderson
Copy link

The dev-master dependency is causing problems for me as well. Drupal Console /Drupal Consoel Core 1.0.0-rc14, Drupal 8.2.5, symfony/console 2.8.15.

Initial symptom:

Fatal error: require(): Failed opening required '.../vendor/composer/../dflydev/dot-access-configuration/src/Dflydev/DotAccessConfiguration/YamlFileConfigurationBuilder.php' (include_path='.:/usr/share/pear:/usr/share/php') in .../vendor/symfony/class-loader/ApcClassLoader.php on line 110

Then, after composer update (which apparently updated nothing, just rewrote the autoload files):

Error: Class 'Dflydev\DotAccessConfiguration\YamlFileConfigurationBuilder' not found in Drupal\Console\Core\Utils\ConfigurationManager->loadConfiguration() (line 86 of .../vendor/drupal/console-core/src/Utils/ConfigurationManager.php).

It seems that dev-master of dflydev/dot-access-configuration has drifted, and no longer works with Drupal Console 1.0.0-rc14. Since rc14 is for Drupal 8.2.5, and Symfony 3.x is only in dev releases of Drupal (didn't check today, but last I heard even dev was back to 2.x), couldn't you require the stable tag in your rc releases, and dev-master in your dev branch? As @grasmash says, it's frustrating when the dependencies of an rc release drift over time.

@greg-1-anderson
Copy link

composer require dflydev/dot-access-configuration:1.0.1 is not a viable workaround, as that conflicts with the dev-master request in drupal/console-core.

Wonders if there's a way to define a Composer version alias via a Composer command.

@greg-1-anderson
Copy link

Like https://getcomposer.org/doc/articles/aliases.md, but for the command line.

@greg-1-anderson
Copy link

greg-1-anderson commented Jan 10, 2017

composer require 'dflydev/dot-access-configuration:1.0.1 as dev-master' almost does the trick, except I get:

The .git directory is missing from ...

Might work if I get that back, though. I think I stripped it deliberately.

UPDATE FOR POSTERITY: The only problem here was that I had deleted my .git directory. The above composer require command is a viable workaround here, if using Drupal Console 1.0.0-rc14

@greg-1-anderson
Copy link

.git directories are another reason why requiring dev-master from an rc release is really inconvenient.

@jmolivas
Copy link
Member

looking at this @greg-1-anderson, thanks for the information

@greg-1-anderson
Copy link

Confirmed that dflydev/dot-access-configuration:1.0.1 works with Drupal Console 1.0.0-rc14 and Drupal 8.2.5.

@jmolivas
Copy link
Member

Tagging an rc15 today cc: @greg-1-anderson @grasmash

@jmolivas
Copy link
Member

Fixed with #135

@grasmash
Copy link
Author

@jmolivas What did you do about needing the has() method? I'm petitioning for a 1.1.0 release :)

dflydev/dflydev-dot-access-data#5
https://twitter.com/grasmash/status/822476053256015872

@greg-1-anderson
Copy link

@jmolivas We could still use an rc15 tag as well. Do you have an updated estimate on when that will be available?

@grasmash
Copy link
Author

https://github.com/dflydev/dflydev-dot-access-data/releases/tag/v1.1.0 was released!

@jmolivas
Copy link
Member

@grasmash @greg-1-anderson RC-15 tagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants