Add validation to create files on generator class #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ao2
reviewed
Nov 21, 2017
src/Generator/Generator.php
Outdated
| throw new \InvalidArgumentException( | ||
| sprintf( | ||
| 'Path "%s" is invalid. You need to provide a valid path.', | ||
| $parameters["path"] |
There was a problem hiding this comment.
Is parameters["path"] always set? Wouldn't it be safer to use dirname($target) here too? Maybe putting that in a variable at the start of the function, since it's used multiple times.
There was a problem hiding this comment.
@harold20 did you see this comment?
|
Thanks. JFYI, on temporary git branches it is usually considered acceptable to Not a big deal for drupal-console as I've seen @jmolivas take care of that, just a general remark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.