Support new installers location. Avoid infinite loop in translator. Fix #363

[eiriksm]

No description provided.

[jmolivas]

@enzolutions @harold20 can you take a look at this based on a conversation on slack seems like is caused by this change on the composer/installers composer/installers@4aa453a#diff-2cb8fec6869068770a69d146dbcde76b

[clemens-tolboom]

See my comment in hechoendrupal/drupal-console#4129 (comment)

[TonyTheFerg]

Thanks, this fixed a memory error I began receiving when trying to ./drupal module:install MODULE after a recent composer update

[dwkitchen]

The resolved the issues for me as well.

[rfsbsb]

I can confirm this fix the problem for me as well.

[amaisano]

Should the files in the new location be gitignored?

[enzolutions]

Thanks to @eiriksm for the code and the rest of you for testing.

I will accept this PR and create a new release today.

@clemens-tolboom there is something we could to fix the issue in composer/installer of drupal-composer/drupal-project? BTW thanks for your help in that matter

[clemens-tolboom]

Is there something we could to fix the issue in composer/installer of drupal-composer/drupal-project?

@enzolutions I've tested this commit. Works fine for me. We don't have to do anything right? Unless I missed something.

People have to:

• revert their hotfix from [console] Infinite loop in Drupal\Console\Core\Utils\TranslatorManager->buildCoreLanguageDirectory when $coreLanguageDirectory does not exist drupal-console#4129 (comment)
• rm -rf vendor/drupal/console-en
• composer install which will install console-en into PROJECT_ROOT/console/language/console-en

Correct me if I'm wrong.

[clemens-tolboom]

Ai ... I forgot to mention installing latest version of drupal/console (I did a git pull)

[jmolivas]

@clemens-tolboom you will probably want to add console/language to your .gitignore file.

[AlexSkrypnyk]

@jmolivas this "hanging" directory started to appear in all projects that use console after the update. Is it possible to avoid the creation of this dir altogether? Also, how come it is doing it in the root of the repo and not in the vendor dir? Is this a bug? Thanks

[clemens-tolboom]

AFAIK the idea of the console/language directory is you can add your own translation there and manage those in your own (git) workflow. That is why drupal-composer/drupal-project#509 added it to .gitignore to ignore https://github.com/hechoendrupal/drupal-console-en and potential other public translations.

So IMHO it is not a bug.

[AlexSkrypnyk]

@clemens-tolboom Thank you for explanation.

Created #366

[jmolivas]

This was related to an old PR composer/installers#311 merged to the composer/installers repository that is no longer required.

But got fixed on latest release of the drupal-console project
https://github.com/hechoendrupal/drupal-console/releases/tag/1.9.3