Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer package type #3447

Merged
merged 1 commit into from
Jul 22, 2017

Conversation

gapple
Copy link
Contributor

@gapple gapple commented Jul 21, 2017

Since Drupal Console is now installed as a project requirement instead of as a standalone application, my understanding is that the type property in composer.json should be updated.

  • composer.lock is ignored if a package is installed within a project as a dependency.
  • The Packagist page displays the setup command for Drupal Console as composer create-project drupal/console instead of composer require drupal/console.

@cburschka
Copy link
Contributor

If composer.lock is removed, this could mean DC can safely require doctrine/collections as ^1.3 rather than 1.3.0 again, leaving it to the local composer to resolve to the versions that are compatible with the installed PHP version.

(#3365)

@jmolivas jmolivas modified the milestone: RC-26 Jul 22, 2017
@jmolivas jmolivas merged commit 256d563 into hechoendrupal:master Jul 22, 2017
@jmolivas
Copy link
Member

@gapple Thanks for your contribution, your PR was merged. This will be included on the next release.

@jmolivas
Copy link
Member

jmolivas commented Jul 22, 2017

@gapple @cburschka Should we send another PR to remove the composer.lock file to fix the doctrine/collections issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants