Space attributes properly in nodeToString

hecrj · Mar 10, 2019 · 6cd8621 · 6cd8621
1 parent 43c641a
commit 6cd8621
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [2.3.1] - 2019-03-10
+### Changed
+- `Html.Parser.nodeToString` spaces attributes properly.
+
 ## [2.3.0] - 2019-03-10
 ### Added
 - `Html.Parser.nodeToString` to turn parser nodes back into its HTML representation.
@@ -42,7 +46,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 [named-character-references]: https://www.w3.org/TR/html5/syntax.html#named-character-references
 
-[Unreleased]: https://github.com/hecrj/html-parser/compare/2.3.0...HEAD
+[Unreleased]: https://github.com/hecrj/html-parser/compare/2.3.1...HEAD
+[2.3.1]: https://github.com/hecrj/html-parser/compare/2.3.0...2.3.1
 [2.3.0]: https://github.com/hecrj/html-parser/compare/2.2.0...2.3.0
 [2.2.0]: https://github.com/hecrj/html-parser/compare/2.1.0...2.2.0
 [2.1.0]: https://github.com/hecrj/html-parser/compare/2.0.1...2.1.0

diff --git a/elm.json b/elm.json
@@ -3,7 +3,7 @@
     "name": "hecrj/html-parser",
     "summary": "Parse HTML 5 in Elm",
     "license": "BSD-3-Clause",
-    "version": "2.3.0",
+    "version": "2.3.1",
     "exposed-modules": [
         "Html.Parser",
         "Html.Parser.Util"

diff --git a/src/Html/Parser.elm b/src/Html/Parser.elm
@@ -111,7 +111,7 @@ nodeToString node_ =
                             ""
 
                         _ ->
-                            " " ++ String.join "" (List.map attributeToString attributes)
+                            " " ++ String.join " " (List.map attributeToString attributes)
             in
             if isVoidElement name then
                 String.concat

diff --git a/tests/Main.elm b/tests/Main.elm
@@ -108,6 +108,15 @@ nodeToStringTests =
                     ]
                     |> Html.Parser.nodeToString
                     |> Expect.equal "<div><p>Hello,</p><p>World!</p></div>"
+        , test "multiple attributes" <|
+            \_ ->
+                Element "a"
+                    [ ( "href", "https://elm-lang.org" )
+                    , ( "alt", "Elm website" )
+                    ]
+                    [ Text "Elm" ]
+                    |> Html.Parser.nodeToString
+                    |> Expect.equal "<a href=\"https://elm-lang.org\" alt=\"Elm website\">Elm</a>"
         , test "void element" <|
             \_ ->
                 Element "br" [] [ Element "a" [] [ Text "should be ignored" ] ]