Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use immutable device ref when building GlyphBrush #29

Merged
merged 1 commit into from
Dec 15, 2019
Merged

Use immutable device ref when building GlyphBrush #29

merged 1 commit into from
Dec 15, 2019

Conversation

antonok-edm
Copy link
Contributor

In wgpu it seems like pipeline setup methods generally accept the wgpu::Device by immutable reference. It works fine this way (Pipeline::new only requires an immutable reference), so I updated the API for creating a GlyphBrush to reflect that.

@hecrj hecrj added the enhancement New feature or request label Dec 15, 2019
@hecrj hecrj added this to the 0.7.0 milestone Dec 15, 2019
@hecrj
Copy link
Owner

hecrj commented Dec 15, 2019 •
edited
Loading

This is related to #26 and #12.

Let's merge it. I think the chances of wgpu changing this are lower now.

Thanks! 🥂

@hecrj hecrj merged commit 0a1023a into hecrj:master Dec 15, 2019
@antonok-edm antonok-edm deleted the remove-unnecessary-mut-device branch December 16, 2019 17:46
@hecrj hecrj mentioned this pull request Dec 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@antonok-edm @hecrj