Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

408 fix recheck #415

Merged
merged 2 commits into from
Jul 23, 2022
Merged

408 fix recheck #415

merged 2 commits into from
Jul 23, 2022

Conversation

TysonMN
Copy link
Member

@TysonMN TysonMN commented Jul 21, 2022

Fixes #408

@TysonMN

This comment was marked as outdated.

@AlexeyRaga

This comment was marked as outdated.

@TysonMN

This comment was marked as outdated.

@AlexeyRaga

This comment was marked as outdated.

@AlexeyRaga

This comment was marked as outdated.

@TysonMN

This comment was marked as outdated.

@TysonMN

This comment was marked as outdated.

Copy link
Member

@dharmaturtle dharmaturtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes in my use case as well. A few very minor suggestions, but otherwise LGTM!

As side commentary, I'm not fond of making the test dependent on the shrinking behavior, but I don't feel strongly about it. One possible solution is to steal from my example in #408:

        let mutable target = false
        property {
            let! _ = // some random unused gen
            Expect.isTrue target
        }

But again, I don't feel strongly about this.

tests/Hedgehog.Tests/PropertyTests.fs Outdated Show resolved Hide resolved
tests/Hedgehog.Tests/PropertyTests.fs Show resolved Hide resolved
src/Hedgehog/Property.fs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@TysonMN

This comment was marked as outdated.

@TysonMN TysonMN merged commit 36b06f0 into hedgehogqa:master Jul 23, 2022
@TysonMN TysonMN deleted the 408_fix_recheck branch July 23, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

recheck always fails
3 participants